Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix a replication panic causing crashes #5074

Merged
merged 2 commits into from
Feb 4, 2023
Merged

Hotfix a replication panic causing crashes #5074

merged 2 commits into from
Feb 4, 2023

Conversation

davidporter-id-au
Copy link
Member

@davidporter-id-au davidporter-id-au commented Feb 4, 2023 •
edited
Loading

There's an uncaught panic in this codepath which crashes in the presence of probably corrupt data. The issue raises the wider question of uncaught panics not being handled in this processor, but I'll address that in a followup

@davidporter-id-au davidporter-id-au enabled auto-merge (squash) February 4, 2023 18:39
Groxx
Groxx approved these changes Feb 4, 2023
View reviewed changes
Copy link
Member

@Groxx Groxx left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, though I am curious how this happens - out-of-order replication or corrupt data maybe? I'm not familiar with the related code, but it does seem like data existing should be a safe assumption in general.

@davidporter-id-au davidporter-id-au merged commit 7670ab2 into master Feb 4, 2023
@davidporter-id-au davidporter-id-au deleted the hotfix/panic-in-replication branch February 4, 2023 19:37
@coveralls
Copy link

Pull Request Test Coverage Report for Build 01861dc3-72e2-41e2-b66d-a099ae65b7d0

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 58 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+0.02%) to 57.182%
Files with Coverage Reduction New Missed Lines %
service/history/queue/timer_queue_processor_base.go 1 77.26%
common/task/weightedRoundRobinTaskScheduler.go 2 89.64%
service/history/execution/mutable_state_util.go 2 36.04%
service/history/task/transfer_standby_task_executor.go 2 86.82%
service/matching/matcher.go 2 91.46%
common/cache/lru.go 3 90.73%
common/task/fifoTaskScheduler.go 3 84.54%
service/matching/taskListManager.go 5 75.87%
service/history/execution/mutable_state_task_refresher.go 38 56.65%
Totals Coverage Status
Change from base Build 01860b50-d443-492e-82ed-8d5bfcdc85c8: 0.02%
Covered Lines: 84904
Relevant Lines: 148479
💛 - Coveralls

@davidporter-id-au davidporter-id-au mentioned this pull request Feb 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@demirkayaender demirkayaender demirkayaender approved these changes

@Groxx Groxx Groxx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidporter-id-au @coveralls @Groxx @demirkayaender